From b65ac0d3709d278f4d5128487bbe6c0be832774c Mon Sep 17 00:00:00 2001 From: Gabriel De Los Rios Date: Thu, 25 Dec 2025 13:07:53 -0300 Subject: [PATCH] fix: check for form validity b4 submitting --- src/app/components/contact-form/contact-form.ts | 1 + src/app/pages/edit/edit.spec.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/components/contact-form/contact-form.ts b/src/app/components/contact-form/contact-form.ts index 2db682a..3bf025e 100644 --- a/src/app/components/contact-form/contact-form.ts +++ b/src/app/components/contact-form/contact-form.ts @@ -26,6 +26,7 @@ export class ContactForm { protected phoneErrorsDictionary = new PhoneFieldErroresDictionary().getDictionary(); handleSubmit(contactForm: ContactFormValue) { + if (this.form().invalid) return; if (contactForm.company === null || contactForm.name === null || contactForm.phone === null) return; const contact = new ContactDTO( diff --git a/src/app/pages/edit/edit.spec.ts b/src/app/pages/edit/edit.spec.ts index c067e97..c2a0533 100644 --- a/src/app/pages/edit/edit.spec.ts +++ b/src/app/pages/edit/edit.spec.ts @@ -21,7 +21,7 @@ describe('Edit', () => { let CONTACT_MOCK: ContactDTO; beforeEach(async () => { - CONTACT_MOCK = new ContactDTO(1, 'mock', 'mock', 'mock'); + CONTACT_MOCK = new ContactDTO(1, 'mock', 'mock', '123456789012'); activatedRoute = jasmine.createSpyObj(ActivatedRoute.name, [], { data: of({ contact: CONTACT_MOCK }), });