From 736a658323ad7e9533463f3ceba83264863b52b6 Mon Sep 17 00:00:00 2001 From: Gabriel De Los Rios Date: Mon, 16 Feb 2026 22:38:48 -0300 Subject: [PATCH] refactor: base members to be abstract as default values are senseless --- src/app/components/chain-add/chain-add.ts | 4 ++-- src/app/components/settings-base-add/settings-base-add.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/components/chain-add/chain-add.ts b/src/app/components/chain-add/chain-add.ts index df1f64d..370befb 100644 --- a/src/app/components/chain-add/chain-add.ts +++ b/src/app/components/chain-add/chain-add.ts @@ -19,8 +19,8 @@ import { SettingsBaseAdd } from '../settings-base-add/settings-base-add'; }) export class ChainAdd extends SettingsBaseAdd { private readonly chainSettings = inject(ChainSettings); - override readonly form = new ChainFormGroup(); - override title = 'settings.chain.new_chain'; + readonly form = new ChainFormGroup(); + title = 'settings.chain.new_chain'; async save() { const name = this.form.controls.name.value; diff --git a/src/app/components/settings-base-add/settings-base-add.ts b/src/app/components/settings-base-add/settings-base-add.ts index c04dbb5..aa62be4 100644 --- a/src/app/components/settings-base-add/settings-base-add.ts +++ b/src/app/components/settings-base-add/settings-base-add.ts @@ -1,8 +1,8 @@ import { FormGroup } from '@angular/forms'; export abstract class SettingsBaseAdd { - title = ''; - form = new FormGroup({}) + abstract title: string; + abstract form: FormGroup; protected abstract save(): Promise }